Migrate run-make/doctests-runtool to rmake
#124711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
jieyouxu
approved these changes
May 4, 2024
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
|
@bors r- Actually one nit |
bors
added
S-waiting-on-author
jieyouxu
requested changes
May 4, 2024
Comment on lines
271
to
276
| /// Specify the edition year. | ||
| pub fn edition(&mut self, edition: &str) -> &mut Self { | ||
| self.cmd.arg("--edition"); | ||
| self.cmd.arg(edition); | ||
| self | ||
| } |
There was a problem hiding this comment.
This shouldn't be on impl_common_headers because that macro is designed to be usable for arbitrary command wrappers, so this should probably be on Rustc and Rustdoc. Some code duplication there is okay imo.
There was a problem hiding this comment.
Oh I see. Sounds good to me!
|
Feel free to r=me after making the change and CI is green. |
GuillaumeGomez
force-pushed
the
migrate-doctests-runtool
branch
from
4328880
to
a64ba04
Compare
|
@bors r=jieyouxu rollup |
bors
added
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
May 5, 2024
…ntool, r=jieyouxu Migrate `run-make/doctests-runtool` to rmake Part of rust-lang#121876. The first commit is making the `edition` method common to `Rustc` and `Rustdoc` as I'll need it for the doctest in rust-lang#123974. r? `@jieyouxu`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#122253 (Support Result<T, E> across FFI when niche optimization can be used) - rust-lang#123892 (Document That `f16` And `f128` Hardware Support is Limited) - rust-lang#124458 (Implement lldb formattter for "clang encoded" enums (LLDB 18.1+)) - rust-lang#124459 (Stabilize exclusive_range_pattern) - rust-lang#124711 (Migrate `run-make/doctests-runtool` to rmake) - rust-lang#124725 (Meta: Enable the brand new triagebot transfer command) - rust-lang#124727 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#122253 (Support Result<T, E> across FFI when niche optimization can be used) - rust-lang#123892 (Document That `f16` And `f128` Hardware Support is Limited) - rust-lang#124458 (Implement lldb formattter for "clang encoded" enums (LLDB 18.1+)) - rust-lang#124459 (Stabilize exclusive_range_pattern) - rust-lang#124711 (Migrate `run-make/doctests-runtool` to rmake) - rust-lang#124725 (Meta: Enable the brand new triagebot transfer command) - rust-lang#124727 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
|
☀️ Test successful - checks-actions |
|
This PR has been merged by accident, without the full test suite being run. It was my fault (#124631 got merged and it broke our CI). @GuillaumeGomez Could you please create a new PR with your branch against the latest version of |
|
Doing that when I arrive at the hotel. |
|
Are you sure this is the one? Seems like the failure is: Did I miss something? |
|
Ah ok I see, it's part of #124753 apparently. Let's see there if something is missing. |
fmease
added a commit
to fmease/rust
that referenced
this pull request
May 5, 2024
…erminism, r=jieyouxu Migrate `run-make/rustdoc-error-lines` to new `rmake.rs` Part of rust-lang#121876. There was a weird naming inconsistency with `input`/`output`. A few tests write `.arg("-o").arg(path)` and the `output` method was actually the command output. So instead, I renamed the original `output` into `command_output` so that I could create the `output` method with the expected effect (and updated the tests to use it too). EDIT: The first two commits come from rust-lang#124711. Some weird things happened recently pparently. ^^' r? `@jieyouxu`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 6, 2024
…erminism, r=jieyouxu Migrate `run-make/rustdoc-error-lines` to new `rmake.rs` Part of rust-lang#121876. There was a weird naming inconsistency with `input`/`output`. A few tests write `.arg("-o").arg(path)` and the `output` method was actually the command output. So instead, I renamed the original `output` into `command_output` so that I could create the `output` method with the expected effect (and updated the tests to use it too). EDIT: The first two commits come from rust-lang#124711. Some weird things happened recently pparently. ^^' r? ``@jieyouxu``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2024
…minism, r=jieyouxu Migrate `run-make/rustdoc-error-lines` to new `rmake.rs` Part of rust-lang#121876. There was a weird naming inconsistency with `input`/`output`. A few tests write `.arg("-o").arg(path)` and the `output` method was actually the command output. So instead, I renamed the original `output` into `command_output` so that I could create the `output` method with the expected effect (and updated the tests to use it too). EDIT: The first two commits come from rust-lang#124711. Some weird things happened recently pparently. ^^' r? `@jieyouxu`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
May 11, 2024
…=jieyouxu Migrate `run-make/rustdoc-error-lines` to new `rmake.rs` Part of rust-lang/rust#121876. There was a weird naming inconsistency with `input`/`output`. A few tests write `.arg("-o").arg(path)` and the `output` method was actually the command output. So instead, I renamed the original `output` into `command_output` so that I could create the `output` method with the expected effect (and updated the tests to use it too). EDIT: The first two commits come from rust-lang/rust#124711. Some weird things happened recently pparently. ^^' r? `@jieyouxu`
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 24, 2024
…=jieyouxu Migrate `run-make/rustdoc-error-lines` to new `rmake.rs` Part of rust-lang/rust#121876. There was a weird naming inconsistency with `input`/`output`. A few tests write `.arg("-o").arg(path)` and the `output` method was actually the command output. So instead, I renamed the original `output` into `command_output` so that I could create the `output` method with the expected effect (and updated the tests to use it too). EDIT: The first two commits come from rust-lang/rust#124711. Some weird things happened recently pparently. ^^' r? `@jieyouxu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #121876.
The first commit is making the
editionmethod common toRustcandRustdocas I'll need it for the doctest in #123974.r? @jieyouxu