Migrate run make const fn mir #126270
Merged
Migrate run make const fn mir #126270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
|
This PR modifies cc @jieyouxu The run-make-support library was changed cc @jieyouxu |
jieyouxu
reviewed
Jun 11, 2024
Comment on lines
+103
to
+109
| // If we can bless (meaning we have a file to write into and the `RUSTC_BLESS_TEST` | ||
| // environment variable set), then we write into the file and return. |
There was a problem hiding this comment.
I'll take note to also write this into the support library docs, we probably also should document this in rustc-dev-guide for run-make tests?
There was a problem hiding this comment.
I suppose so. Didn't know there was a guide. ^^'
|
@rustbot author |
rustbot
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
migrate-run-make-const_fn_mir
branch
from
14bcf0c
to
f8ecd1c
Compare
|
For the dev guide, I'll need to send a PR to the target repository so nothing I can do here directly. Applied suggestion for the test. @bors ready |
jieyouxu
approved these changes
Jun 13, 2024
Too many bots. 😅 |
GuillaumeGomez
force-pushed
the
migrate-run-make-const_fn_mir
branch
from
f8ecd1c
to
60ce260
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
migrate-run-make-const_fn_mir
branch
from
60ce260
to
1336292
Compare
|
Not sure why it failed in the GCC backend. Rebased, let's see if it's happy now. |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
migrate-run-make-const_fn_mir
branch
from
1336292
to
5f4111f
Compare
|
@bors r=jieyouxu rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 13, 2024
…nst_fn_mir, r=jieyouxu Migrate run make const fn mir Part of rust-lang#121876. r? `@jieyouxu`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 14, 2024
…nst_fn_mir, r=jieyouxu Migrate run make const fn mir Part of rust-lang#121876. r? ``@jieyouxu``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 14, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#123962 (change method resolution to constrain hidden types instead of rejecting method candidates) - rust-lang#124884 (place explicit lifetime bound after generic param) - rust-lang#126244 (Update fuchsia commit, and SDK to 21.20240610.2.1) - rust-lang#126270 (Migrate run make const fn mir) - rust-lang#126320 (Avoid ICES after reporting errors on erroneous patterns) - rust-lang#126343 (Remove some msys2 utils) - rust-lang#126351 (std::unix::fs::link using direct linkat call for Solaris.) - rust-lang#126368 (Remove some unnecessary crate dependencies.) - rust-lang#126386 (Migrate `run-make/allow-non-lint-warnings-cmdline` to `rmake.rs`) - rust-lang#126449 (Fill out missing Windows support information) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 14, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#123962 (change method resolution to constrain hidden types instead of rejecting method candidates) - rust-lang#126244 (Update fuchsia commit, and SDK to 21.20240610.2.1) - rust-lang#126270 (Migrate run make const fn mir) - rust-lang#126320 (Avoid ICES after reporting errors on erroneous patterns) - rust-lang#126449 (Fill out missing Windows support information) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 14, 2024
Rollup merge of rust-lang#126270 - GuillaumeGomez:migrate-run-make-const_fn_mir, r=jieyouxu Migrate run make const fn mir Part of rust-lang#121876. r? ```@jieyouxu```
bjorn3
reviewed
Jun 17, 2024
| @@ -0,0 +1,8 @@ | |||
| // The `needs-unwind -Cpanic=abort` gives a different MIR output. | |||
There was a problem hiding this comment.
This should have been //@ needs-unwind. # needs-unwind in Makefile tests ignores the test when -Cpanic=abort is the default, like with cg_clif or when compiling for wasm.
There was a problem hiding this comment.
Worked around this in rust-lang/rustc_codegen_cranelift@e241176
There was a problem hiding this comment.
Sorry, fixing it and reverting your mir changes as well.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 17, 2024
…ion, r=bjorn3 Add `run-make/const_fn_mir` missing test annotation Fixes comment from rust-lang#126270. r? `@bjorn3`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 17, 2024
Rollup merge of rust-lang#126580 - GuillaumeGomez:add-missing-annotation, r=bjorn3 Add `run-make/const_fn_mir` missing test annotation Fixes comment from rust-lang#126270. r? `@bjorn3`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #121876.
r? @jieyouxu