Fix for broken salt cmd return codes - issue #7013 #11337

techdragon · 2014-03-18T22:22:00Z

new test related states that can be used to provide success / failure on request.
fixed the broken logic chain that handles return codes
both when the minion decides what retcode to propagate to the master
and when the master decides what return code to return to the invoked salt cmd
added new log.debug and log.trace statements to assist with further work on ensuring return
codes are properly handled by all components of salt.
should fix Salt exit codes are inconsistent and undocumented #7013

- new test related states that can be used to provide success / failure on request. - fixed the broken logic chain that handles return codes both when the minion decides what retcode to propagate to the master and when the master decides what return code to return to the invoked salt cmd - added new log.debug and log.trace statements to assist with further work on ensuring return codes are properly handled by all components of salt.

ghost · 2014-03-18T22:22:30Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/2514/

Build Log
last 15 lines

[...truncated 27 lines...]
    at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.revParse(CliGitAPIImpl.java:416)
    at hudson.plugins.git.GitAPI.revParse(GitAPI.java:257)
    at hudson.plugins.git.RevisionParameterAction.toRevision(RevisionParameterAction.java:83)
    at hudson.plugins.git.GitSCM.determineRevisionToBuild(GitSCM.java:787)
    at hudson.plugins.git.GitSCM.checkout(GitSCM.java:879)
    at hudson.model.AbstractProject.checkout(AbstractProject.java:1414)
    at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:671)
    at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:88)
    at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:580)
    at com.tikal.jenkins.plugins.multijob.MultiJobBuild$MultiJobRunnerImpl.run(MultiJobBuild.java:134)
    at hudson.model.Run.execute(Run.java:1676)
    at com.tikal.jenkins.plugins.multijob.MultiJobBuild.run(MultiJobBuild.java:73)
    at hudson.model.ResourceController.execute(ResourceController.java:88)
    at hudson.model.Executor.run(Executor.java:231)

ghost · 2014-03-18T23:18:41Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/2516/

Build Log
last 15 lines

[...truncated 16 lines...]
Seen branch in repository origin/develop
Seen branch in repository origin/no_ipv6
Seen branch in repository origin/pillar_mod
Seen 11 remote branches
Checking out Revision a5153ba0c83f54e00aaa92832b04961bfedf0eaf (origin/develop)
Starting build job salt-pr-rs-ubuntu12.04.
Starting build job salt-pr-lint.
Finished Build : #2069 of Job : salt-pr-rs-ubuntu12.04 with status :FAILURE
Finished Build : #2201 of Job : salt-pr-lint with status :FAILURE
Build step 'MultiJob Phase' marked build as failure

Deleting project workspace... 
done

ghost · 2014-03-19T03:04:03Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/2533/

ghost · 2014-03-19T03:04:57Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/2534/

ghost · 2014-03-19T03:18:22Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/2535/

- Fixed bad logic in data handling block. - Fixed and refactored the test state to be more complete and in line with coding standards.

ghost · 2014-03-19T08:26:37Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/2543/

- Added newlines to fix E8302(expected-2-blank-lines,-found-0) - Disabled pylint checks for E8712(comparison-to-True-should-be-'if-cond-is-True:'-or-'if-cond:') and documented my reason

ghost · 2014-03-19T08:52:08Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/2544/

ghost · 2014-03-19T09:21:07Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/2545/

techdragon · 2014-03-19T11:35:32Z

The console log doesnt provide enough information on why the profile error is being propagated. Investigating back through the salt cloud code in order to identify a possible cause of the error.

Error: There was a profile error: Executing the command '/tmp/.saltcloud/deploy.sh -c /tmp/.saltcloud -D -g https://github.com/techdragon/salt.git -n git 024169128f0ed5f4fbf6ce55737e6eadc33e249c' failed

http://jenkins.saltstack.com/job/salt-pr-rs-ubuntu12.04/2091/consoleFull

thatch45 · 2014-03-19T16:45:07Z

salt/cli/__init__.py

+                        err = 'All Minions did not return a retcode of 0. One or more minions had a problem'
+                        # NOTE: This could probably be made more informative.
+                        # I chose 11 since its not in use.
+                        raise SaltSystemExit(code=11, msg=err)


We might not want to raise an error like this, but just return with the error return code, what do you think?

If you mean just passing on the return code that is generated from the minion. The problem is what to do when you get multiple different return codes. For instance one minion has no errors, another has a single state return retcode 1, another minion returns retcode 2. How to represent this? I've been contemplating options on how to provide the information and feel that given the possible permutations we really have little option as far as the process return/exit code but to choose a distinct error code for this 'minion failures' use case.

Oh, no, I like your approach with a static exit code! I just think we should use sys.exit instead of raise SaltSystemExit

thatch45 · 2014-03-19T16:46:06Z

Sorry about the test system failures, we were having issues yesterday with the rackspace API (or rather, they stopped working for some 20+ hours)
I am going to try and get this to test again.

ghost · 2014-03-19T16:51:11Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/2551/

techdragon · 2014-03-20T04:37:15Z

Still getting issues with the bootstraping code failing.

Error: There was a profile error: Executing the command '/tmp/.saltcloud/deploy.sh -c /tmp/.saltcloud -D -g https://github.com/techdragon/salt.git -n git 024169128f0ed5f4fbf6ce55737e6eadc33e249c' failed

But it seems the cause is #11338 and #11357
since the last line before the failure is
package init file 'salt/templates/__init__.py' not found (or not a regular file)

…ly runs on my PR.

ghost · 2014-03-20T05:21:07Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/2567/

- fixed pep8 issue - added more logic to check_state_result logic to handle list results properly and return false. - ordered the check_state_result unit tests more logically. All the data type tests are now before the content & logic handling checks - discovered duplicate test in check_state_result unit tests and removed it, both tests were asserting using the same data {'host': []}

ghost · 2014-03-20T07:13:56Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/2568/

Fix for broken salt cmd return codes - issue #7013

s0undt3ch · 2014-03-24T16:25:23Z

salt/states/test.py

+                'new': 'Were pretending really hard that we changed something'
+                }
+            }
+    elif changes == True:  # pylint: disable=E8712


why would

elif changes is True:

be less readable?

kiorky · 2014-03-26T01:08:02Z

I think this breaked the saltmod module

kiorky · 2014-03-26T01:08:08Z

cc @thatch45 .

kiorky · 2014-03-26T01:09:30Z

we used to check the highstate return in this way:

  m_state = salt.utils.check_state_result({minionid: m_ret})

and it seems that now the function waits, something like that:

  m_state = salt.utils.check_state_result(m_ret)

kiorky · 2014-03-26T01:09:49Z

Im sending a PR but it would be good to have a confirmation on this

Fix saltmod & saltutils due to #11337 & f798c95 breakages

nw0428 · 2014-04-28T19:09:58Z

Was this actually fixed? Currently "salt-call state.highstate" always returns 0 for me!

basepi · 2014-04-28T22:32:36Z

@nw0428 which version of salt?

basepi · 2014-04-28T22:33:01Z

@nw0428 I think this only goes live in the next feature release (codenamed Helium) -- so you'll only see the new behavior if you're running off of the develop branch.

techdragon added 2 commits March 19, 2014 10:58

fixing syntax error.

0798119

another syntax fix

7c23998

Fixing W0632(unbalanced-tuple-unpacking) pylint violation

7e69dd5

Fixes

7bf555e

- Fixed bad logic in data handling block. - Fixed and refactored the test state to be more complete and in line with coding standards.

Pylint fixes

d359c25

- Added newlines to fix E8302(expected-2-blank-lines,-found-0) - Disabled pylint checks for E8712(comparison-to-True-should-be-'if-cond-is-True:'-or-'if-cond:') and documented my reason

Fixing E8261(at-least-two-spaces-before-inline-comment)

0241691

thatch45 reviewed Mar 19, 2014
View reviewed changes

thatch45 closed this Mar 19, 2014

thatch45 reopened this Mar 19, 2014

Trying to fix integration test failing on a missing file so CI actual…

281262f

…ly runs on my PR.

thatch45 added a commit that referenced this pull request Mar 22, 2014

Merge pull request #11337 from techdragon/fix-hightstate-failure-retcode

4af873d

Fix for broken salt cmd return codes - issue #7013

thatch45 merged commit 4af873d into saltstack:develop Mar 22, 2014

thedrow mentioned this pull request Mar 22, 2014

Enable highstate failure retcode #10504

Closed

techdragon mentioned this pull request Mar 23, 2014

salt-ssh: exit code is always 0 #7876

Closed

s0undt3ch reviewed Mar 24, 2014
View reviewed changes

kiorky mentioned this pull request Mar 26, 2014

Fix saltmod & saltutils due to #11337 & f798c953 breakages #11527

Merged

thatch45 added a commit that referenced this pull request Mar 26, 2014

Merge pull request #11527 from makinacorpus/hf33

eeb418b

Fix saltmod & saltutils due to #11337 & f798c95 breakages

cachedout mentioned this pull request Mar 28, 2014

file.blockreplace function fails after upgrade to 2014.1.1 #11626

Closed

This was referenced May 13, 2014

restructure test cases and/or document CI logic #12721

Closed

Integration tests for checking simple outputter return data #12707

Merged

salt-call state.highstate should optionally use exit codes to report failures #4176

Closed

This was referenced Jul 12, 2014

Document exit codes #14155

Closed

Salt exit codes are inconsistent and undocumented #7013

Closed

basepi mentioned this pull request Jul 23, 2014

Return system exit codes on failures #14435

Closed

jfindlay mentioned this pull request Dec 3, 2014

salt exit codes #18510

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for broken salt cmd return codes - issue #7013 #11337

Fix for broken salt cmd return codes - issue #7013 #11337

techdragon commented Mar 18, 2014

ghost commented Mar 18, 2014

ghost commented Mar 18, 2014

ghost commented Mar 19, 2014

ghost commented Mar 19, 2014

ghost commented Mar 19, 2014

ghost commented Mar 19, 2014

ghost commented Mar 19, 2014

ghost commented Mar 19, 2014

techdragon commented Mar 19, 2014

thatch45 Mar 19, 2014

techdragon Mar 20, 2014

thatch45 Mar 21, 2014

thatch45 commented Mar 19, 2014

ghost commented Mar 19, 2014

techdragon commented Mar 20, 2014

ghost commented Mar 20, 2014

ghost commented Mar 20, 2014

s0undt3ch Mar 24, 2014

kiorky commented Mar 26, 2014

kiorky commented Mar 26, 2014

kiorky commented Mar 26, 2014

kiorky commented Mar 26, 2014

nw0428 commented Apr 28, 2014

basepi commented Apr 28, 2014

basepi commented Apr 28, 2014

Fix for broken salt cmd return codes - issue #7013 #11337

Fix for broken salt cmd return codes - issue #7013 #11337

Conversation

techdragon commented Mar 18, 2014

ghost commented Mar 18, 2014

ghost commented Mar 18, 2014

ghost commented Mar 19, 2014

ghost commented Mar 19, 2014

ghost commented Mar 19, 2014

ghost commented Mar 19, 2014

ghost commented Mar 19, 2014

ghost commented Mar 19, 2014

techdragon commented Mar 19, 2014

thatch45 Mar 19, 2014

Choose a reason for hiding this comment

techdragon Mar 20, 2014

Choose a reason for hiding this comment

thatch45 Mar 21, 2014

Choose a reason for hiding this comment

thatch45 commented Mar 19, 2014

ghost commented Mar 19, 2014

techdragon commented Mar 20, 2014

ghost commented Mar 20, 2014

ghost commented Mar 20, 2014

s0undt3ch Mar 24, 2014

Choose a reason for hiding this comment

kiorky commented Mar 26, 2014

kiorky commented Mar 26, 2014

kiorky commented Mar 26, 2014

kiorky commented Mar 26, 2014

nw0428 commented Apr 28, 2014

basepi commented Apr 28, 2014

basepi commented Apr 28, 2014