Exposed simple cookie functions via Main interface. #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fumieval
reviewed
Apr 11, 2024
Web/Scotty.hs
Outdated
| @@ -52,6 +52,7 @@ module Web.Scotty | |||
| -- * Types | |||
| , ScottyM, ActionM, RoutePattern, File, Content(..), Kilobytes, ErrorHandler, Handler(..) | |||
| , ScottyState, defaultScottyState | |||
| , module Web.Scotty.Cookie | |||
There was a problem hiding this comment.
I think explicit export list is more preferable because the type signatures show up in the Haddock.
|
Thanks for the suggestion @fumieval! Added explicit function list. |
fumieval
approved these changes
Apr 11, 2024
|
Thank you @tusharad , great! Could you please also update the example program in |
|
Hi @ocramz , I changed the |
|
Thank you @tusharad ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #350 issue. I have exposed the cookie module from
Web.Scotty&Web.Scotty.Trans. Though I only exported simple functions of the cookie module which are:If the user wants to use
SetCookiefunctions then the user should importWeb.Scotty.Cookie.Let me know if I should expose all the functions or not.
Thanks.
@ocramz