Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds postephemeral handler to slacktest to audit outgoing messages #1105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtintes
Copy link

@mtintes mtintes commented Aug 30, 2022

The Changes

PostEphemeral was not exposing messages in the outgoing messages on slacktest. This is mostly a copy-paste from how postMessage handles that with the addition that we use the userId that gets handed into the method.

@mtintes
Copy link
Author

mtintes commented Sep 14, 2022

Just wanted to check in on this to see if there were any questions or concerns surrounding it that I could help clear up. I kind of just threw this in because I needed it to write some tests and most of our sends are ephemeral messages.

@mtintes
Copy link
Author

mtintes commented Feb 8, 2023

Hey just wanted to circle back and see if you had any thoughts on this? Happy to do the work if you have alternative ideas.

@mtintes
Copy link
Author

mtintes commented Nov 6, 2023

hey @kanata2 I know it's been a while, but just want to follow up on this. Happy to update it and whatnot. Or if you have another idea I would happily work through it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants