Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: Update Debian base image to use bookworm base image and builder #121

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Docker: Update Debian base image to use bookworm base image and builder #121

merged 1 commit into from
Dec 5, 2023

Conversation

tashian
Copy link
Contributor

@tashian tashian commented Dec 5, 2023

I've tested that step-kms-plugin builds and runs properly using the debian:bookworm base image and golang:bookworm builder image

Note: smallstep/cli#1080 will need to be merged and released before this will build.

@tashian tashian requested review from maraino and a team as code owners December 5, 2023 02:02
@tashian tashian mentioned this pull request Dec 5, 2023
Merged
maraino
maraino approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 📖 🪱

@tashian tashian merged commit 837f4ed into main Dec 5, 2023
15 checks passed
@tashian tashian deleted the carl/debian-bookworm branch December 5, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraino maraino maraino approved these changes

Assignees
No one assigned
Labels
needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tashian @maraino