Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: remove Unpin bound on throttle methods #5105

Merged
merged 1 commit into from
Oct 14, 2022
Merged

time: remove Unpin bound on throttle methods #5105

merged 1 commit into from
Oct 14, 2022

Conversation

Darksonn
Copy link
Contributor

Yes, these methods are safe without T: Unpin since the module contains no unsafe anywhere.

@Darksonn Darksonn added M-time Module: tokio/time A-tokio-stream Area: The tokio-stream crate labels Oct 14, 2022
@Darksonn Darksonn requested a review from hds October 14, 2022 07:43
hds
hds approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Darksonn Darksonn enabled auto-merge (squash) October 14, 2022 08:39
@Darksonn Darksonn merged commit bf5eed8 into master Oct 14, 2022
@Darksonn Darksonn deleted the alice/throttle-unpin-ok branch October 14, 2022 08:44
@Darksonn Darksonn mentioned this pull request Feb 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hds hds hds approved these changes

Assignees
No one assigned
Labels
A-tokio-stream Area: The tokio-stream crate M-time Module: tokio/time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Darksonn @hds