Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zygisk): Fix Zygisk on GrapheneOS Android 14 #7606

Closed
wants to merge 2 commits into from
Closed

fix(zygisk): Fix Zygisk on GrapheneOS Android 14 #7606

wants to merge 2 commits into from

Conversation

pixincreate
Copy link

@pixincreate pixincreate commented Dec 9, 2023

The discussions have been done in these places:

And specially this

GrapheneOS code changes can be seen here

P.S: I don't have any context about how Magisk works at core level. I cherry-picked HuskyDG's commit and modified it to make it work with Magisk.

Tests are run here and test on 34 failed.

@vvb2060 vvb2060 closed this Dec 9, 2023
@yujincheng08 yujincheng08 added the wontfix Not going to fix it label Dec 9, 2023
@pixincreate
Copy link
Author

pixincreate commented Dec 9, 2023

Ok, kindly update your Magisk's documentation explaining what operating systems / devices are supported (since the vision of Magisk today seems to cover basically the topline Pixel models running stock OS, Samsung devices and nothing else) so that we don't waste our time trying to fix it in here or ask for support.

To what I understand, @topjohnwu never had a vision of making this project to target only specific OSes but rather had a broad vision of a project that serves an entire open source android community.

@Robotition
Copy link

literally why was this closed? this PR properly fixes GrapheneOS support

@Robotition
Copy link

perhaps someone could fork?

@canyie
Copy link
Collaborator

canyie commented Dec 10, 2023

GrapheneOS hates root and any modification, No reason to be compatible with operating systems that hate us.

@Robotition
Copy link

Maybe because GrapheneOS is a properly hardened Operating system? People are free to root their device if they please while still having a more secure rooted experience than on AOSP.

@yujincheng08
Copy link
Collaborator

Magisk wont make extra effort to support any specific customized ROM. Otherwise anyone can create a customized ROM that breaks Magisk and Magisk has to constantly update to support it.

Basically, Magisk tries its best to support most OEM OSes (unless those intentionally anti-root, e.g. vivo's OSes). As for customized ROMs, well, since Magisk will try to make sure it works on their upstreams, they can easily avoid breaking Magisk. If they still break Magisk, it means they dont care about, or even they are aganist Magisk. In that case, there's no reason for Magisk to still add special support.

@pixincreate
Copy link
Author

GrapheneOS hates root and any modification, No reason to be compatible with operating systems that hate us.

There's nothing termed as "hating root" or "hating you". It is just that the project's threat model asks for it to be avoided. However but that does not mean that users of GrapheneOS should be deprived of root just because upstream does some changes with the way a certain feature work.

Magisk wont make extra effort to support any specific customized ROM. Otherwise anyone can create a customized ROM that breaks Magisk and Magisk has to constantly update to support it.

I agree with this to an extent. But Magisk has also down significant efforts to make it compatible with Samsung devices that contradicts with what is mentioned above. Samsung did do a lot of stuffs that goes against Magisk but still Magisk was made to support it unlike in other cases like Vivo (FuntouchOS).

@yujincheng08
Copy link
Collaborator

yujincheng08 commented Dec 10, 2023

Samsung's OSes are OEM OSes, so Magisk will try to support. For VIVO, we have tried but with no luck, otherwise VIVO devices are supported.

@pixincreate
Copy link
Author

Why not GrapheneOS? Of course it is not an OEM, neither it is an after market Operating System but rather an alternate Operating System that supports verified boot. I'm saying this after using using it for more than 10 months and it feels like an OS from an OEM given that it is always up-to-date (they did support Android 14 within 4 -5 days of it being released into public way too early than any other OEM out there after Google, in case you're unaware) unlike other custom ROMs.

@canyie
Copy link
Collaborator

canyie commented Dec 10, 2023

Maybe because GrapheneOS is a properly hardened Operating system? People are free to root their device if they please while still having a more secure rooted experience than on AOSP.

GrapheneOS/platform_frameworks_base@9a9282b
They introduce changes that would even break normal apps for their so-called "security". Why we should take effect to support a custom system that even doesn't pass CTS? Only systems that comply with the Android Compatibility Definition Document are Android.

@pixincreate
Copy link
Author

They introduce changes that would even break normal apps for their so-called "security".

I agree with this, and they're doing their stuff of trying to make it work with normal apps and I don't talk about that.

Only systems that comply with the Android Compatibility Definition Document are Android.

Any OS that is built on top of AOSP is Android. Android CDD is a requirement documentation that has to be met to make a certain version of Android say 14 compatible and it is what the first itself states:

This document enumerates the requirements that must be met in order for devices to be compatible with Android 14.

And there is no where mentioned that systems that comply with Android CDD only has to be considered Android.

CTS is exected to not pass as GrapheneOS is not a partner of Google by any means to get approval to get Play Services running.

Sources:
https://source.android.com/docs/compatibility/14/android-14-cdd
https://developer.android.com/google/play/integrity/verdicts

@yujincheng08
Copy link
Collaborator

yujincheng08 commented Dec 10, 2023

Why not GrapheneOS? Of course it is not an OEM, neither it is an after market Operating System but rather an alternate Operating System that supports verified boot.

not a reason to support. every customized rom can highlight their feature.

and, as i hv said, if its built upon AOSP, they can avoid breaking magisk (because magisk supports AOSP). if they really break magisk, that means they dont care about magisk. you should ask them to avoid breaking magisk (or submit their so-called security changes to AOSP), rather than begging here.

Repository owner locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix Not going to fix it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants