-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing compatibility errors w/Gin and Windows. #3537
base: v3-alpha
Are you sure you want to change the base?
Conversation
…ontentTypeSniffer, for Gin (and other framework) compatibility.
Thanks for doing this. What's the parsing error? |
honestly, I don't even know any more. The It must be related to my generate command, but I'm not sure.
|
Are you ok if we take out the syso change? That line currently works fine in the default template. |
80a4532
to
aa58218
Compare
Done! ✅
Unfortunately I don't, my desktop app is the paid version of my open-source fasten-onprem project. But it's mostly just some custom setup and then calling: app := application.New(application.Options{
Assets: application.AssetOptions{
Middleware: FileServerMiddleware,
Handler: ginWebServerEngine.Handler(),
},
...
} |
Is this still in progress? I ran into same issue using echo and The app panics here: https://github.com/labstack/echo/blob/master/response.go#L91 |
This is for echo & possibly other golang backend framework compatiblity. See wailsapp#3537
😬 Sorry I haven't opened a issue about these yet. They've been living in my branch for more than 6months at this point, made sense to move them upstream
Description
contentTypeSniffer
struct is not compatible with the Gin response, which requires thehttp.CloseNotifier
interface.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor
.Test Configuration
Checklist:
website/src/pages/changelog.mdx
with details of this PR