Add tests for wasmer-cli create-{exe,obj} commands #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epilys
changed the title
epilys
requested review from
fschutt and
syrusakbary
and removed request for
syrusakbary
epilys
force-pushed
the
create-exe-tests
branch
2 times, most recently
from
3764dd8
to
2f2b895
Compare
syrusakbary
reviewed
Aug 19, 2022
fschutt
previously requested changes
Aug 19, 2022
bors bot
added a commit
that referenced
this pull request
Aug 19, 2022
3117: Add tests for wasmer-cli create-{exe,obj} commands r=epilys a=epilys
Unified generated objects interfaces: both static and serialized objects
expose the same function signature to create the module:
wasm_module_t* wasmer_object_module_new(wasm_store_t* store, const char* module_name);
Closes #3071
Co-authored-by: Manos Pitsidianakis <manos@wasmer.io>
epilys
force-pushed
the
create-exe-tests
branch
from
2f2b895
to
6bb3ae4
Compare
|
View diff to previous PR version: |
Unified generated objects interfaces: both static and serialized objects expose the same function signature to create the module: wasm_module_t* wasmer_object_module_new(wasm_store_t* store, const char* module_name);
…at flag Test that serialized and symbol formats work both in create-exe and create-obj.
epilys
force-pushed
the
create-exe-tests
branch
from
6bb3ae4
to
4fdbd34
Compare
fschutt
approved these changes
Aug 22, 2022
syrusakbary
approved these changes
Aug 22, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified generated objects interfaces: both static and serialized objects
expose the same function signature to create the module:
wasm_module_t* wasmer_object_module_new(wasm_store_t* store, const char* module_name);
Closes #3071